Fix incompatibility with DragonAPI #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d order after dapi
Dream-Master
added
the
🚧 Testing on Zeta
|
Does the dependencies info really affect mixin and asm? |
Member
|
No, (early) mixins usually run last but still before mod discovery |
Author
Yep turns out that wasn't needed anymore. Its removed now. |
Alexdoru
requested changes
Nov 21, 2025
Member
Alexdoru
left a comment
Alexdoru
left a comment
There was a problem hiding this comment.
can you split this mixin into two files and only load the dragon api mixins when the mod is present
Alexdoru
approved these changes
Nov 27, 2025
Author
|
Ah nice, thank u |
Dream-Master
removed
the
🚧 Testing on Zeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an incompatibility with DragonAPI, where both mods were intercepting the "populate" method in ChunkProviderServer (DAPI with ASM, GC with Mixin).
I also added DAPI to the load order, to make sure it first patches that class so we can't break it for them.
Should fix ReikaKalseki/Reika_Mods_Issues#3458
Note: I get an Error from the RFG Plugin for the Annotation (due to missing sources), but that does not impact the functionality.